Alon Bar-Lev has posted comments on this change.
Change subject: webadmin: [WIP,improvment] expose simple config values access
......................................................................
Patch Set 2:
Had short talk with Roy.
Apparently, we do have cache at client side. This means that a callback is
totally useless as no blocking code is executed when getting configuration
options.
I expect a patch with a new interface like this one also replace the old
callback/async interface with a simpler one. As adding yet another interface
just make the already complex code to be even more complex.
It should not be that difficult because instead of:
f(){
statement1
get(x, fcb)
statement2
}
fcb(v) {
statement3
}
We can just combine the f and fcb.
f(){
statement1
v = get(x)
statement2
statement3
}
I don't think that it should take more time to merge and review, especially if
we remove extra unneeded complexity from our current code.
Thanks,
Alon
--
To view, visit http://gerrit.ovirt.org/11141
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2712ed87474577b8d0ff5d57bca9e120dc075981
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
