Gilad Chaplik has posted comments on this change.
Change subject: engine: Corrections to Event.equal to avoid confusions and
unexpected behaviors.
......................................................................
Patch Set 2: (2 inline comments)
Asaf, thanks for pointing that out, IEventListener should also move to uicompat.
....................................................
File
backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Event.java
Line 99: }
Line 100: }
Line 101:
Line 102: @Override
Line 103: public int hashCode() {
so? will this code ever be executed?
Line 104: final int prime = 31;
Line 105: int result = 1;
Line 106: result = prime * result + ((privateName == null) ? 0 :
privateName.hashCode());
Line 107: result = prime * result + ((privateOwnerType == null) ? 0 :
privateOwnerType.hashCode());
Line 107: result = prime * result + ((privateOwnerType == null) ? 0 :
privateOwnerType.hashCode());
Line 108: return result;
Line 109: }
Line 110: @Override
Line 111: public boolean equals(Object obj) {
you're right, but in this case we are covered by default object.equals. still
no need.
Line 112: if (this == obj)
Line 113: return true;
Line 114: if (obj == null)
Line 115: return false;
--
To view, visit http://gerrit.ovirt.org/10955
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idca42d6a61454162db412429e55898f15152c12d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
