Shireesh Anjal has posted comments on this change.
Change subject: gluster: Override CommandBase.getJobMessageProperties
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java
Line 60:
Line 61: @Override
Line 62: public Map<String, String> getJobMessageProperties() {
Line 63: if (jobProperties == null) {
Line 64: jobProperties = new HashMap<String, String>();
My only concern is that this change here sounds like we're removing some
functionality provided by the base class implementation of
getJobMessageProperties().
As of now, we don't really use any of the MLA related variables in our job
message descriptions, so I guess it is safe.
I'll accept it, since it is coming from you :) and you are planning to change
the base class to make it an abstract method - as mentioned in your last
statement.
Line 65: VDSGroup vdsGroup = getVdsGroup();
Line 66:
jobProperties.put(VdcObjectType.VdsGroups.name().toLowerCase(),
Line 67: vdsGroup == null ? null : vdsGroup.getname());
Line 68: }
--
To view, visit http://gerrit.ovirt.org/10988
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I393621e3f52b343b8dc5916f20497a0da3aa3bf1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
