Shireesh Anjal has posted comments on this change.
Change subject: gluster: Override CommandBase.getJobMessageProperties
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java
Line 59: public Map<String, String> getJobMessageProperties() {
Line 60: if (jobProperties == null) {
Line 61: jobProperties = new HashMap<String, String>();
Line 62: VDSGroup vdsGroup = getVdsGroup();
Line 63:
jobProperties.put(VdcObjectType.VdsGroups.name().toLowerCase(),
Maybe we can use GlusterConstants.CLUSTER here? ${cluster} is far more readable
than ${vdsgroups} in the properties file..
Line 64: vdsGroup == null ? null : vdsGroup.getname());
Line 65: }
Line 66:
Line 67: return jobProperties;
--
To view, visit http://gerrit.ovirt.org/10988
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I393621e3f52b343b8dc5916f20497a0da3aa3bf1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
