Sahina Bose has posted comments on this change.
Change subject: restapi: Rest API for brick advanced details
......................................................................
Patch Set 1: (7 inline comments)
Patch Set to follow with feedback changes
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterBrickDetailsResource.java
Line 7: import org.ovirt.engine.api.model.GlusterBrickAdvancedDetails;
Line 8: import org.ovirt.engine.api.resource.MediaType;
Line 9:
Line 10: @Produces({MediaType.APPLICATION_XML, MediaType.APPLICATION_JSON,
MediaType.APPLICATION_X_YAML})
Line 11: public interface GlusterBrickDetailsResource {
True. Will remove
Line 12:
Line 13: @GET
Line 14: @Formatted
Line 15: public GlusterBrickAdvancedDetails get();
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 2951: <xs:element name="max_std_alloc" type="xs:int" minOccurs="0"
maxOccurs="1"/>
Line 2952: </xs:sequence>
Line 2953: </xs:complexType>
Line 2954:
Line 2955: <xs:complexType name="MemoryPools">
Done for all similar
Line 2956: <xs:sequence>
Line 2957: <xs:annotation>
Line 2958: <xs:appinfo>
Line 2959: <jaxb:property name="MemoryPools"/>
Line 3028: <xs:element ref="gluster_volume" minOccurs="0"
maxOccurs="1"/>
Line 3029: <xs:element name="server_id" type="xs:string"
minOccurs="0" maxOccurs="1"/>
Line 3030: <xs:element name="brick_dir" type="xs:string"
minOccurs="0" maxOccurs="1"/>
Line 3031: <xs:element ref="status" minOccurs="0" maxOccurs="1"/>
Line 3032: <xs:element ref="brick_details" minOccurs="0"
maxOccurs="1"/>
Ok.
Line 3033: </xs:sequence>
Line 3034: </xs:extension>
Line 3035: </xs:complexContent>
Line 3036: </xs:complexType>
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResource.java
Line 87: return populateAdvancedDetails(model,entity);
Line 88: }
Line 89:
Line 90: private GlusterBrick populateAdvancedDetails(GlusterBrick model,
GlusterBrickEntity entity) {
Line 91: //TODO: check if advanced details could not be found, should
this be ignored?
Ok. sounds good.
Line 92:
Line 93: GlusterVolumeEntity volumeEntity =
getEntity(GlusterVolumeEntity.class,
Line 94:
VdcQueryType.GetGlusterVolumeById,
Line 95: new
IdQueryParameters(entity.getVolumeId()),
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResourceTest.java
Line 111:
Line 112: resource.setParent(bricksResourceMock);
Line 113: control.replay();
Line 114:
Line 115: verifyModel(resource.get(), 0);
Done
Line 116:
Line 117: }
Line 118:
Line 119: @Test
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GlusterBrickDetailMapper.java
Line 30: GlusterBrickAdvancedDetails model = (toModel == null) ? new
GlusterBrickAdvancedDetails() : toModel;
Line 31:
Line 32: if (fromEntity.getBrickDetails() == null) return model;
Line 33: //Since the getDetails call is for a single brick the list
size should always be 1.
Line 34: //TODO: check-Should Exception be thrown if greater?
ok.
Line 35: BrickDetails detail = (fromEntity.getBrickDetails().size() >
0) ? fromEntity.getBrickDetails().get(0) : null;
Line 36:
Line 37: if (detail == null) return model;
Line 38:
Line 36:
Line 37: if (detail == null) return model;
Line 38:
Line 39: if (detail.getBrickProperties() != null) {
Line 40: BrickProperties props = detail.getBrickProperties();
Done
Line 41: model.setBlockSize(props.getBlockSize());
Line 42: if (StringUtils.isNotEmpty(props.getDevice()))
Line 43: model.setDevice(props.getDevice());
Line 44: model.setFreeSize(props.getFreeSize());
--
To view, visit http://gerrit.ovirt.org/11391
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie219c7cf59fec8a21a54f34959ee5966eed7d524
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
