Shireesh Anjal has posted comments on this change.
Change subject: restapi: Rest API for brick advanced details
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
One minor comment in-line.
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GlusterBrickDetailMapper.java
Line 17:
Line 18: public class GlusterBrickDetailMapper {
Line 19:
Line 20: @Mapping (from=GlusterBrick.class,
to=GlusterVolumeAdvancedDetails.class)
Line 21: public static GlusterVolumeAdvancedDetails map(GlusterBrick model,
GlusterVolumeAdvancedDetails toEntity) {
Do you really need this method?
Line 22: //AdvancedDetails is a read only from server and no support
for setting these.
Line 23: //Hence mapping from REST model to Business entity not
required.
Line 24: GlusterVolumeAdvancedDetails entity = (toEntity == null) ? new
GlusterVolumeAdvancedDetails() : toEntity;
Line 25: return entity;
--
To view, visit http://gerrit.ovirt.org/11391
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie219c7cf59fec8a21a54f34959ee5966eed7d524
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
