Oved Ourfali has posted comments on this change.
Change subject: core: Supporting hard coded ldap servers per domain
......................................................................
Patch Set 4: Looks good to me, approved
(1 inline comment)
minor comment.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/dns/DnsSRVLocator.java
Line 336: }
Line 337: StringBuilder sb = new StringBuilder(host);
Line 338: //Remove the "root DNS" part from the host name
Line 339: //if exists as "." at the end of the host name
Line 340: if (host.lastIndexOf(".") == host.length() -1) {
add a space
Line 341: host = host.substring(0, host.length() - 1);
Line 342: }
Line 343: sb.append(":").append(port);
Line 344: return new SrvRecord(priority, weight, sb.toString());
--
To view, visit http://gerrit.ovirt.org/11064
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0914f2f6d9432ecac0cebee3790eae902a1329a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
