Allon Mureinik has posted comments on this change.
Change subject: engine: Making increase of storage pool master domain version
atomic operation
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(3 inline comments)
looks good, see some minor issues inline.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAO.java
Line 17:
Line 18: /**
Line 19: * Increase master_domain_version of storage pool in DB and return
a new value
Line 20: * @param id
Line 21: * @return
Either document @param and @return, or just remove them.
Line 22: */
Line 23: int increaseStoragePoolMasterVersion(Guid id);
Line 24:
Line 25: /**
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolDAOTest.java
Line 280: }
Line 281:
Line 282: @Test
Line 283: public void testIncreaseStoragePoolMasterVersion() {
Line 284: int result =
dao.increaseStoragePoolMasterVersion(existingPool.getId());
I'd add a get from the DB here, to make it was really updated there.
Line 285: assertEquals(result, existingPool.getmaster_domain_version()
+ 1);
Line 286: }
Line 287:
Line 288: /**
....................................................
Commit Message
Line 6:
Line 7: engine: Making increase of storage pool master domain version atomic
operation
Line 8:
Line 9: The following patch should make an increase of master storage domain
version atomic
Line 10: operation. These is done in order to prevent races and need for cache
reload and also to
s/These/This/
Line 11: make code simple
Line 12:
Line 13: Change-Id: Iaa2657ddfdbf2400f24341b07ab60743d6430481
--
To view, visit http://gerrit.ovirt.org/11500
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa2657ddfdbf2400f24341b07ab60743d6430481
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
