Michael Kublin has posted comments on this change. Change subject: engine: Making increase of storage pool master domain version atomic operation ......................................................................
Patch Set 1: (1 inline comment) 1.Update to the column should be removed from Updatestorage_pool stored procedure. - so why you wrote the following: "reload of StoragePool and StorageDomain should be left - otherwise we might perform reconstruct and update the DB with wrong values (ProceedStorageDomainTreatmentByDomainType() method)". Looks like you are not sure if a value should be reloaded or updated or update should be removed? 2.From brief look seems that the set status in RecoveryStoragePool execute method won't be updated in the db now. - And why I need these ? How a change of status helps me? During reconstruct status of pool is not changed at all. .................................................... File backend/manager/dbscripts/storages_sp.sql Line 40: AS $procedure$ Line 41: BEGIN Line 42: UPDATE storage_pool Line 43: SET description = v_description,name = v_name,storage_pool_type = v_storage_pool_type, Line 44: status = v_status,storage_pool_format_type = v_storage_pool_format_type,master_domain_version = v_master_domain_version, You can remove it , these is not relevant to patch Line 45: spm_vds_id = v_spm_vds_id,compatibility_version = v_compatibility_version, Line 46: _update_date = LOCALTIMESTAMP,quota_enforcement_type=v_quota_enforcement_type Line 47: WHERE id = v_id; Line 48: END; $procedure$ -- To view, visit http://gerrit.ovirt.org/11500 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa2657ddfdbf2400f24341b07ab60743d6430481 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
