Maor Lipchuk has posted comments on this change.
Change subject: core: handle error when iso domain in maintenance
......................................................................
Patch Set 6: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
Line 295: storageDomainId,
Line 296: fileTypeExt,
Line 297: status);
Line 298: }
Line 299: else {
Although formatter does not obligates, consider to put the else at one line
with the brackets when rebasing, as so } else {
Line 300: // Try to refresh the domain of the storage pool id
because its status is active.
Line 301: refreshSucceeded =
Line 302:
refreshIsoDomainFileForStoragePool(storageDomainId,
Line 303: storagePoolId,
--
To view, visit http://gerrit.ovirt.org/11449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide53f42c087ffbc9240cccc033e809ff8117ec8c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
