Alissa Bonas has posted comments on this change.
Change subject: core: Removed unnecessary calls to StringFormat & StringHelper
......................................................................
Patch Set 1: (6 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/tags.java
Line 169: }
Line 170:
Line 171: public StringBuilder GetTagIdAndChildrenIds() {
Line 172: StringBuilder builder = new StringBuilder();
Line 173: builder.append(StringFormat.format("'%1$s'", gettag_id()));
Why didn't you replace here as well?
Line 174:
Line 175: for (tags tag : _children) {
Line 176: builder.append("," + tag.GetTagIdAndChildrenIds());
Line 177: }
Line 179: }
Line 180:
Line 181: public StringBuilder GetTagNameAndChildrenNames() {
Line 182: StringBuilder builder = new StringBuilder();
Line 183: builder.append(StringFormat.format("'%1$s'", gettag_name()));
Why didn't you replace here as well?
Line 184:
Line 185: for (tags tag : _children) {
Line 186: builder.append("," + tag.GetTagNameAndChildrenNames());
Line 187: }
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/vm_pools.java
Line 246: return this.name;
Line 247: }
Line 248:
Line 249: public void setvm_pool_name(String value) {
Line 250: this.name = value;
this is already addressed in Allon's patch "Change Iafac9ca6: core: Don't check
equality in BE setters"
Line 251: }
Line 252:
Line 253: public int getvm_assigned_count() {
Line 254: return vmPoolAssignedCount;
....................................................
File
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ADSyntaxChecker.java
Line 316: } else {
Line 317: phrase.append(so.getBody() + ")");
Line 318: }
Line 319: if (nonEqual) {
Line 320: retval.append(StringFormat.format("(!%1$s)",
phrase));
Did you not change this one on purpose?
Line 321: } else {
Line 322: retval.append(phrase.toString());
Line 323: }
Line 324: nonEqual = false;
....................................................
Commit Message
Line 6:
Line 7: core: Removed unnecessary calls to StringFormat & StringHelper
Line 8:
Line 9: Replaced calls to StringFormat.format to String.format where possible
Line 10: (i.e. not code that compile to GWT) and to simple String concatation
where
string concatenation
Line 11: possible
Line 12: also replaced calls to StringHelper.EqOp calls in
Line 13: String.equals calls in cases that at least one of the args was not null
Line 14:
Line 10: (i.e. not code that compile to GWT) and to simple String concatation
where
Line 11: possible
Line 12: also replaced calls to StringHelper.EqOp calls in
Line 13: String.equals calls in cases that at least one of the args was not null
Line 14:
There are a lot of @Override additions in this patch that are not related to
the strings/format that the patch deals with.
I would either adress them in different patch, or at least mention them in the
commit message.
Line 15: Change-Id: I57dc0d9d30f9e5cd4f0beacc8bfd35fe5023afc1
--
To view, visit http://gerrit.ovirt.org/11659
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57dc0d9d30f9e5cd4f0beacc8bfd35fe5023afc1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
