Tal Nisan has posted comments on this change.
Change subject: core: Removed unnecessary calls to StringFormat & StringHelper
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/tags.java
Line 169: }
Line 170:
Line 171: public StringBuilder GetTagIdAndChildrenIds() {
Line 172: StringBuilder builder = new StringBuilder();
Line 173: builder.append(StringFormat.format("'%1$s'", gettag_id()));
Replaced only the places with simple substitutions, places that will end with
"'" + stringValue + "'" will look better with StringFormat
Line 174:
Line 175: for (tags tag : _children) {
Line 176: builder.append("," + tag.GetTagIdAndChildrenIds());
Line 177: }
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/vm_pools.java
Line 246: return this.name;
Line 247: }
Line 248:
Line 249: public void setvm_pool_name(String value) {
Line 250: this.name = value;
Here also? thought he missed it
Line 251: }
Line 252:
Line 253: public int getvm_assigned_count() {
Line 254: return vmPoolAssignedCount;
--
To view, visit http://gerrit.ovirt.org/11659
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57dc0d9d30f9e5cd4f0beacc8bfd35fe5023afc1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
