Tal Nisan has posted comments on this change.
Change subject: core: Change vm_pools entity to VmPool
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmPoolMapperTest.java
Line 1: package org.ovirt.engine.api.restapi.types;
Line 2:
Line 3: import org.ovirt.engine.api.model.VmPool;
Line 4:
Line 5: public class VmPoolMapperTest extends
AbstractInvertibleMappingTest<VmPool,
org.ovirt.engine.core.common.businessentities.VmPool,
org.ovirt.engine.core.common.businessentities.VmPool> {
Indeed, but the other class with the same name exists only in the REST api and
I didn't want to interfere with the inner workings of the REST api, this is up
for the rest team to decide what they want to do, in any case I wouldn't want
the entity name to be other than VmPool, it fits the standard of the rest of
the entities
Line 6:
Line 7: public VmPoolMapperTest() {
Line 8: super(VmPool.class,
Line 9:
org.ovirt.engine.core.common.businessentities.VmPool.class,
--
To view, visit http://gerrit.ovirt.org/11714
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41147ad4479ed6f31bb25b3f0e86c5f258efe027
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
