Maor Lipchuk has posted comments on this change. Change subject: core: Change vm_pools entity to VmPool ......................................................................
Patch Set 1: I'm not sure I follow your example, vm_static -> VmStatic is the standard way of how that we reflect table names with java classes. vm_pools -> VmPool is not. Although this change will compile and work perfectly, and since the DB change is a pain, I think that it will be better to call the entity simply vmPools and change it to VmPool when we will also change the DB table. but that is only my opinion, I will appreciate other opinions -- To view, visit http://gerrit.ovirt.org/11714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41147ad4479ed6f31bb25b3f0e86c5f258efe027 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
