Sandro Bonazzola has posted comments on this change.
Change subject: packaging: allow interactive NFS exports cleanup with
engine-cleanup
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File packaging/fedora/setup/nfsutils.py
Line 40: logging.debug("Backing up %s into %s", exportFilePath, backupFile)
Line 41: utils.copyFile(exportFilePath, backupFile)
Line 42:
Line 43:
Line 44: def cleanNfsExports(comment, exportFilePath=basedefs.FILE_ETC_EXPORTS):
I agree that it worth to split the logic. But this also implies changes in the
upgrade path from a previous version. Can we consider the split as an
enhancement and open another bug for it?
Line 45: """
Line 46: Remove all the lines added by engine-setup marked by comment from
Line 47: exportFilePath.
Line 48: """
--
To view, visit http://gerrit.ovirt.org/11548
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0548ab358d0cbed32ceff3ceacefc57f1c068df4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
