Sandro Bonazzola has posted comments on this change.
Change subject: packaging: allow interactive NFS exports cleanup with
engine-cleanup
......................................................................
Patch Set 6: (1 inline comment)
the comment behavior is already in the patch
....................................................
File packaging/fedora/setup/nfsutils.py
Line 54: new_lines = []
Line 55: with open(exportFilePath, "r") as exportFile:
Line 56: lines = exportFile.readlines()
Line 57: for line in lines:
Line 58: if comment in line or "#rhev installer" in line:
Yes, the check on "#rhev installer" is for backward compatibility. The comment
passed to cleanNfsExports by engine-cleanup is " %s installer" %
basedefs.APP_NAME.
Line 59: logging.debug("removing %s from %s" % (line,
exportFilePath))
Line 60: path = line.split("\t")[0]
Line 61: removed_exports.append(path)
Line 62: continue
--
To view, visit http://gerrit.ovirt.org/11548
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0548ab358d0cbed32ceff3ceacefc57f1c068df4
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
