Mike Kolesnik has posted comments on this change.
Change subject: engine: slave interfaces are being overridden
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java
Line 108:
Line 109: VdsNetworkInterface existingIface = null;
Line 110: if (iface.getId() != null &&
getExistingIfacesToIds().containsKey(iface.getId())) {
Line 111: existingIface =
getExistingIfacesToIds().get(iface.getId());
Line 112: if (existingIface != null) {
Why would this be null?
Line 113: iface.setName(existingIface.getName());
Line 114: }
Line 115: } else if (StringUtils.isNotEmpty(iface.getName()) &&
getExistingIfaces().containsKey(iface.getName())) {
Line 116: existingIface = getExistingIfaces().get(iface.getName());
Line 113: iface.setName(existingIface.getName());
Line 114: }
Line 115: } else if (StringUtils.isNotEmpty(iface.getName()) &&
getExistingIfaces().containsKey(iface.getName())) {
Line 116: existingIface = getExistingIfaces().get(iface.getName());
Line 117: if (existingIface != null) {
Why would this be null?
Line 118: iface.setId(existingIface.getId());
Line 119: }
Line 120: }
Line 121: }
Line 266:
Line 267: return existingIfaces;
Line 268: }
Line 269:
Line 270: private Map<Guid, VdsNetworkInterface> getExistingIfacesToIds() {
Shouldn't this be named getExistingIfacesByIds ?
Of course field name would have to match
Line 271: if (existingIfacesToIds == null) {
Line 272: existingIfacesToIds =
Entities.businessEntitiesById(getExistingIfaces().values());
Line 273: }
Line 274:
--
To view, visit http://gerrit.ovirt.org/11671
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f38bc399059ad19e93fcad0f360957636ac7045
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
