Muli Salem has posted comments on this change.
Change subject: engine: slave interfaces are being overridden
......................................................................
Patch Set 6: Looks good to me, approved
(1 inline comment)
Other than the minor comment - +2.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NetworkInterfaceValidator.java
Line 65: * </ul>
Line 66: *
Line 67: * @param slave
Line 68: * The network interface represents a slave
Line 69: * @return {@code true} is the slave is configured properly.
s/is/if
Line 70: */
Line 71: private boolean validateSlave(VdsNetworkInterface slave) {
Line 72: return (slave.getBootProtocol() == null ||
slave.getBootProtocol() == NetworkBootProtocol.NONE)
Line 73: && isEmpty(slave.getNetworkName())
--
To view, visit http://gerrit.ovirt.org/11671
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f38bc399059ad19e93fcad0f360957636ac7045
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
