Yair Zaslavsky has posted comments on this change.
Change subject: engine: Fixing compensation for RemoveVmTemplateCommand and
possible other commands
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateParametersBase.java
Line 6:
Line 7: public class VmTemplateParametersBase extends VdcActionParametersBase
implements java.io.Serializable {
Line 8: private static final long serialVersionUID = -8930994274659598061L;
Line 9: private boolean removeTemplateFromDb;
Line 10: private Guid vmTemplateId = Guid.Empty;
Not sure I fully understood why this fixes the problem.
The only difference is that in the new patch all vmTemplateId instances of all
VmTemplateParametersBase reference the same object - Guid.Empty, and in the old
version of the code, each vmTemplateId field references a new object (each one
of them holds the EMPTY_STRING, but the objects are different).
So, not sure I understood how this difference helps.
Line 11: private Guid quotaId;
Line 12: private boolean privateCheckDisksExists;
Line 13:
Line 14: public boolean getCheckDisksExists() {
--
To view, visit http://gerrit.ovirt.org/11813
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb042d6cb8276a3c457a94823e90c1e6936cfa69
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
