Michael Kublin has submitted this change and it was merged. Change subject: engine: Fixing compensation for RemoveVmTemplateCommand and possible other commands ......................................................................
engine: Fixing compensation for RemoveVmTemplateCommand and possible other commands So, the fix is simple - change name. After a restart of engine - RemoveVmTemplate command is created based on parameters, but with old name vmTemplateId did not pass json serialization and get default value - Guid.Empty, which is id of blank template. After that , we are trying to delete blank template and failed (We are lucky) - means command failed, a origin template left with status Locked Change-Id: Ifb042d6cb8276a3c457a94823e90c1e6936cfa69 Signed-off-by: Michael Kublin <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateParametersBase.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11813 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb042d6cb8276a3c457a94823e90c1e6936cfa69 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
