Daniel Erez has uploaded a new change for review. Change subject: core: placeholder handler revert task on failure ......................................................................
core: placeholder handler revert task on failure CreateImagePlaceholderTaskHandler: endWithFailure() should revert task (unlocks the image) since beforeTask() locks the image. Change-Id: I266792d30ce4a2743a19db2b9776a3aea2eedfed Bug-Url: https://bugzilla.redhat.com/907167 Signed-off-by: Daniel Erez <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/CreateImagePlaceholderTaskHandler.java 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/30/11830/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/CreateImagePlaceholderTaskHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/CreateImagePlaceholderTaskHandler.java index c2493ea..58b1f5b 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/CreateImagePlaceholderTaskHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/CreateImagePlaceholderTaskHandler.java @@ -63,6 +63,12 @@ } @Override + public void endWithFailure() { + super.endWithFailure(); + revertTask(); + } + + @Override protected VDSCommandType getRevertVDSCommandType() { return VDSCommandType.DeleteImageGroup; } -- To view, visit http://gerrit.ovirt.org/11830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I266792d30ce4a2743a19db2b9776a3aea2eedfed Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
