Vered Volansky has uploaded a new change for review. Change subject: core: cleanup: remove unnecessary variable and ifs ......................................................................
core: cleanup: remove unnecessary variable and ifs BaseImagesCommand.getImage() used unnecessary auxiliary variable and if statements for clas member mImage assignment, and now only uses class member mImage. Change-Id: If4ce2493c4cda5bc851aafb7a1abdc2dba9a99b5 Signed-off-by: Vered Volansky <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java 1 file changed, 3 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/31/11831/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java index a966e44..cde53ae 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java @@ -59,14 +59,9 @@ protected DiskImage getImage() { if (mImage == null) { - DiskImage image = getDiskImageDao().get(getImageId()); - if (image != null) { - mImage = image; - } else { - image = getDiskImageDao().getSnapshotById(getImageId()); - if (image != null) { - mImage = image; - } + mImage = getDiskImageDao().get(getImageId()); + if (mImage == null) { + mImage = getDiskImageDao().getSnapshotById(getImageId()); } } return mImage; -- To view, visit http://gerrit.ovirt.org/11831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If4ce2493c4cda5bc851aafb7a1abdc2dba9a99b5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
