Moti Asayag has posted comments on this change.
Change subject: engine: Added NetworkHelper class
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkHelper.java
Line 1: package org.ovirt.engine.core.bll.network;
why under bll module? wouldn't it used by other projects that can't access the
bll ?
Line 2:
Line 3: import org.apache.commons.lang.StringUtils;
Line 4: import org.ovirt.engine.core.common.businessentities.network.Network;
Line 5: import org.ovirt.engine.core.common.config.Config;
Line 6: import org.ovirt.engine.core.common.config.ConfigValues;
Line 7:
Line 8: /**
Line 9: * Class to hold common static methods for {@link Network} that are
used in several different places.
Line 10: */
why introducing a new class instead extending the NetworkUtils which shares the
same characteristics as this class?
Line 11: public class NetworkHelper {
Line 12:
Line 13: /**
Line 14: * Determine if the network is management network.
Line 17: * The network to check.
Line 18: * @return <code>true</code> iff the network is a management
network.
Line 19: */
Line 20: public static boolean managementNetwork(Network net) {
Line 21: return StringUtils.equals(net.getName(), Config.<String>
GetValue(ConfigValues.ManagementNetwork));
why not use the return value of the management network by the config value for
the comparison ? It shouldn't be null...
Line 22: }
--
To view, visit http://gerrit.ovirt.org/11835
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I27844da800326e338ec193b4ffd1fb2ee6aef034
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
