Moti Asayag has posted comments on this change.

Change subject: engine: Added management network check
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
Line 188:      *            The network to check.
Line 189:      * @return <code>true</code> iff the network is a management 
network.
Line 190:      */
Line 191:     public static boolean isManagementNetwork(Network net) {
Line 192:         return Config.<String> 
GetValue(ConfigValues.ManagementNetwork).equalsIgnoreCase(net.getName());
please use case-sensitive comparison
Line 193:     }


--
To view, visit http://gerrit.ovirt.org/11835
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27844da800326e338ec193b4ffd1fb2ee6aef034
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to