Allon Mureinik has posted comments on this change.
Change subject: core: Removed the ResXResourceReader class
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
Giving -1 just to get this off my radar.
Please see question inline (not so sure your way is a bad idea, just not sure I
fully understand it) and fix the bug Maor noticed.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
Line 735: }
Line 736: checkMessages();
Line 737: }
Line 738:
Line 739: private static Map<String, String> readMessagesFromBundle() {
why do you need to convert the bundle to a map, instead of using it directly?
Line 740: try {
Line 741: ResourceBundle bundle =
ResourceBundle.getBundle(APP_ERRORS_MESSAGES_FILE_NAME);
Line 742: Map<String, String> messages = new HashMap<String,
String>();
Line 743: for (String key : bundle.keySet()) {
....................................................
Commit Message
Line 5: CommitDate: 2013-02-07 02:58:55 +0200
Line 6:
Line 7: core: Removed the ResXResourceReader class
Line 8:
Line 9: Removed the class ResXResourceReader from the compat module, this class
s/, this/. This/
Line 10: was used to load the audit log messages from the properties file, it
was
Line 11: used only in AuditLogDirector, the logic in the class was improved and
moved
Line 12: to a method inside AuditLogDirector
Line 13:
Line 6:
Line 7: core: Removed the ResXResourceReader class
Line 8:
Line 9: Removed the class ResXResourceReader from the compat module, this class
Line 10: was used to load the audit log messages from the properties file, it
was
s/it was used only/and was only used/
Line 11: used only in AuditLogDirector, the logic in the class was improved and
moved
Line 12: to a method inside AuditLogDirector
Line 13:
Line 14:
--
To view, visit http://gerrit.ovirt.org/11827
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If60caa71d0b66d79279409ca534a419b89dcba75
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
