Allon Mureinik has posted comments on this change.
Change subject: core: Removed the ResXResourceReader class
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
logging is still bonky.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
Line 724: messages.put(type, bundle.getString(key));
Line 725: } else {
Line 726: log.errorFormat("The type {0} appears more then
once in audit log messages bundle with the values '{1}' and '{2}'",
Line 727: messages.get(type),
Line 728: bundle.getString(key));
wait - you have three format elements here {0}, {1} and {2}, but only two input
params.
I'm guessing the first should be "key".
Line 729: }
Line 730: } catch (Exception e) {
Line 731: log.errorFormat("Cannot convert the string {0} to
AuditLogType, the key does not exist in the AuditLogType declared types",
Line 732: bundle.getString(key));
--
To view, visit http://gerrit.ovirt.org/11827
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If60caa71d0b66d79279409ca534a419b89dcba75
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
