Liron Aravot has posted comments on this change.
Change subject: core,restapi,webadmin: Added description field to storage domain
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File backend/manager/dbscripts/storages_sp.sql
Line 297:
Line 298: Create or replace FUNCTION Updatestorage_domain_static(v_id UUID,
Line 299: v_storage VARCHAR(250),
Line 300: v_storage_name VARCHAR(250),
Line 301: v_description VARCHAR(250),
why different length than line 271?
Line 302: v_storage_type INTEGER,
Line 303: v_storage_domain_type INTEGER,
Line 304: v_storage_domain_format_type INTEGER,
Line 305: v_last_time_used_as_master BIGINT)
....................................................
File
backend/manager/dbscripts/upgrade/03_02_0430_add_storage_static_description_column.sql
Line 1: select fn_db_add_column('storage_domain_static', 'description',
'VARCHAR(4000)');
is it the same size as other description fields?
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java
Line 19: @ValidName(message = "VALIDATION.STORAGE_DOMAIN.NAME.INVALID",
groups = { CreateEntity.class, UpdateEntity.class })
Line 20: @Size(min = 1, max = BusinessEntitiesDefinitions.STORAGE_NAME_SIZE)
Line 21: private String name = "";
Line 22:
Line 23: private String description;
what about validation to the field like the one for the name?
Line 24:
Line 25: private StorageDomainType storageType = StorageDomainType.Master;
Line 26:
Line 27: private StorageType storagePoolType = StorageType.UNKNOWN;
--
To view, visit http://gerrit.ovirt.org/11929
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I86bcd7c52e5d9cad7c3cb30561718203537ab459
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
