Maor Lipchuk has posted comments on this change.

Change subject: core,restapi,webadmin: Added description field to storage domain
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java
Line 19:     @ValidName(message = "VALIDATION.STORAGE_DOMAIN.NAME.INVALID", 
groups = { CreateEntity.class, UpdateEntity.class })
Line 20:     @Size(min = 1, max = BusinessEntitiesDefinitions.STORAGE_NAME_SIZE)
Line 21:     private String name = "";
Line 22: 
Line 23:     private String description;
You can use here @Size(max = BusinessEntitiesDefinitions.GENERAL_MAX_SIZE)
Line 24: 
Line 25:     private StorageDomainType storageType = StorageDomainType.Master;
Line 26: 
Line 27:     private StorageType storagePoolType = StorageType.UNKNOWN;


--
To view, visit http://gerrit.ovirt.org/11929
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86bcd7c52e5d9cad7c3cb30561718203537ab459
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to