Yair Zaslavsky has posted comments on this change. Change subject: core: When updating entity name the event... ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RenamedEntityInfoProvider.java Line 6: Line 7: public String getEntityName(); Line 8: public String getOldName(); Line 9: public String getNewName(); Line 10: public void setId(AuditLogableBase logable); What id? command ID? entity ID? this is not clear as it provides commands with a method of "setId" -- To view, visit http://gerrit.ovirt.org/11756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17f0049ca0ffb1a3868ba404b112a8c10ee7778e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
