Yair Zaslavsky has posted comments on this change.
Change subject: core: When updating entity name the event...
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RenamedEntityInfoProvider.java
Line 1: package org.ovirt.engine.core.bll;
Line 2:
Line 3: import
org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogableBase;
Line 4:
Line 5: public interface RenamedEntityInfoProvider {
I don't like Renamable offer - who is renamable? the command? or the entity?
Line 6:
Line 7: public String getEntityName();
Line 8: public String getOldName();
Line 9: public String getNewName();
Line 6:
Line 7: public String getEntityName();
Line 8: public String getOldName();
Line 9: public String getNewName();
Line 10: public void setId(AuditLogableBase logable);
Moti - you are right + following your suggestion about renamable which I did
not like, I think getOldName, getNewName should be getEntityNewName and
getEntityOldName (once again - which name are we referring to ? the command
name or the entity name?)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ReflectionUtils.java
Line 106: return annotation;
Line 107: }
Line 108: }
Line 109: return null;
Line 110: }
Yes, if we go with "instanceof" as I suggested.
Line 111:
Line 112: /**
Line 113: * Gets a method (without parametrs) return value
Line 114: *
--
To view, visit http://gerrit.ovirt.org/11756
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17f0049ca0ffb1a3868ba404b112a8c10ee7778e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
