Ravi Nori has uploaded a new change for review. Change subject: tools : taskcleaner.sh utility returns always 0 as return code ......................................................................
tools : taskcleaner.sh utility returns always 0 as return code taskcleaner.sh always returns exit code of 0 even on failure Change-Id: If0c61616e0c4962ee141baba7eda40341d4f721b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=910796 Signed-off-by: Ravi Nori <[email protected]> --- M backend/manager/tools/dbutils/taskcleaner.sh 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/03/12103/1 diff --git a/backend/manager/tools/dbutils/taskcleaner.sh b/backend/manager/tools/dbutils/taskcleaner.sh index 9bb217c..5dfc8bd 100755 --- a/backend/manager/tools/dbutils/taskcleaner.sh +++ b/backend/manager/tools/dbutils/taskcleaner.sh @@ -106,7 +106,10 @@ # Install taskcleaner procedures psql -U ${USERNAME} -h ${SERVERNAME} -p ${PORT} -f ./taskcleaner_sp.sql ${DATABASE} > /dev/null - +status =`echo $?` +if [$status -gt 0]; then + exit $status +fi if [ "${TASK_ID}" != "" -o "${COMMAND_ID}" != "" -o "${CLEAR_ALL}" = "true" -o "${CLEAR_COMPENSATION}" = "true" -o "${CLEAR_JOB_STEPS}" = "true" ]; then #delete operations block if [ "${TASK_ID}" != "" ]; then @@ -234,6 +237,6 @@ fi psql -U ${USERNAME} -h ${SERVERNAME} -p ${PORT} -c "${CMD1}${CMD2}" -x ${DATABASE} - +status =`echo $?` popd>/dev/null -exit $? +exit $status -- To view, visit http://gerrit.ovirt.org/12103 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If0c61616e0c4962ee141baba7eda40341d4f721b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
