Tal Nisan has posted comments on this change. Change subject: core: Cleanup VmPoolCommandBase#isVmFree ......................................................................
Patch Set 1: (1 inline comment) Logic wise seems ok aside for the minor grammar comment, but I must say that I don't really dig this code, it's a commandbase that holds method which are called from a non-command context like a util class, maybe it'll be better to extract the methods to an outside class? I don't think the commandbase is the place for them since they are used in other places too .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java Line 151: return DbFacade.getInstance().getSnapshotDao().exists(vmId, SnapshotType.STATELESS); Line 152: } Line 153: Line 154: /** Line 155: * Check if a specific VM is free. A VM is considered free if it isn't attached to user and not during trieng to a user will be more correct here imo And what is "trieng"? Line 156: * @param vmId Line 157: * The vm id. Line 158: * @param messages Line 159: * The messages. -- To view, visit http://gerrit.ovirt.org/12124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e59cd811d7c318674587df877d29a10d8ef220f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
