Allon Mureinik has submitted this change and it was merged. Change subject: core: Cleanup VmPoolCommandBase#isVmFree ......................................................................
core: Cleanup VmPoolCommandBase#isVmFree Cleaned up VmPoolCommandBase's isVmFree method to make it more readable: 1. Adopted an early-return paradigm 2. Removed redundant null checks on messages. This method is only called from canAttachNonPrestartedVmToUser, which always passes a new ArrayList instance. Change-Id: I2e59cd811d7c318674587df877d29a10d8ef220f Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java 1 file changed, 59 insertions(+), 68 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e59cd811d7c318674587df877d29a10d8ef220f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
