Allon Mureinik has posted comments on this change.
Change subject: core: RemoveSnapshotCommad: move image validation
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
Line 172: }
Line 173:
Line 174: if (hasImages()) {
Line 175: // Check the VM's images
Line 176: if (!validateImages()) {
I'm not changing the semantics if this command as part of a cleanup - this will
be done in a later patch.
Line 177: return false;
Line 178: }
Line 179:
Line 180: // check that we are not deleting the template
Line 211:
Line 212: protected boolean validateImages() {
Line 213: return
ImagesHandler.PerformImagesChecks(getReturnValue().getCanDoActionMessages(),
Line 214: getVm().getStoragePoolId(), Guid.Empty,
Line 215: hasImages(), hasImages(), hasImages(), hasImages(),
true, true, getDiskDao().getAllForVm(getVmId()));
indeed.
will fix.
Line 216: }
Line 217:
Line 218: protected boolean validateImageNotInTemplate() {
Line 219: return
getVmTemplateDAO().get(getRepresentativeSourceImageId()) == null;
--
To view, visit http://gerrit.ovirt.org/12132
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e491f97134c3017fd53bfc159cf47f83ba74ae7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
