Tal Nisan has posted comments on this change. Change subject: core: RemoveSnapshotCommad: move image validation ......................................................................
Patch Set 2: Looks good to me, approved (1 inline comment) Minor comment .................................................... Commit Message Line 3: AuthorDate: 2013-02-17 09:38:46 +0200 Line 4: Commit: Allon Mureinik <[email protected]> Line 5: CommitDate: 2013-02-17 13:56:05 +0200 Line 6: Line 7: core: RemoveSnapshotCommad: move image validation Commad = Command :) Line 8: Line 9: RemoveSnapshotCommand's canDoAction performs several validations only if Line 10: the VM has images, and several regardless. Line 11: -- To view, visit http://gerrit.ovirt.org/12132 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e491f97134c3017fd53bfc159cf47f83ba74ae7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
