Allon Mureinik has uploaded a new change for review. Change subject: webadmin: Remove useless null check ......................................................................
webadmin: Remove useless null check Remove a useless null check from VdcQueryReturnValue_CustomFieldSerializer's serialize and deserialize methods. nulls are checked explicitly in the begging of the respective functions, so it cannot be null at their ends. Change-Id: I5a14e8a8705cdd3be8ea24b6da7288bedb01a453 Signed-off-by: Allon Mureinik <[email protected]> --- M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryReturnValue_CustomFieldSerializer.java 1 file changed, 2 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/52/12252/1 diff --git a/frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryReturnValue_CustomFieldSerializer.java b/frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryReturnValue_CustomFieldSerializer.java index fc3b115..fe225df 100644 --- a/frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryReturnValue_CustomFieldSerializer.java +++ b/frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryReturnValue_CustomFieldSerializer.java @@ -63,9 +63,7 @@ instance.setReturnValue((IVdcQueryable) streamReader.readObject()); } else if (type.equals("UNKNOWN")) { deserializedAs = "UNKNOWN"; - if (type != null) { - instance.setReturnValue(streamReader.readObject()); - } + instance.setReturnValue(streamReader.readObject()); } } @@ -148,9 +146,7 @@ } else { serializedAs = "UNKNOWN"; streamWriter.writeString(serializedAs); - if (returnValue != null) { - streamWriter.writeObject(instance.getReturnValue()); - } + streamWriter.writeObject(instance.getReturnValue()); } } -- To view, visit http://gerrit.ovirt.org/12252 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5a14e8a8705cdd3be8ea24b6da7288bedb01a453 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
