Allon Mureinik has posted comments on this change.
Change subject: webadmin: Remove useless null check
......................................................................
Patch Set 1: Verified
(2 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryReturnValue_CustomFieldSerializer.java
Line 21:
Line 22: String type = streamReader.readString();
Line 23: Object returnValue;
Line 24: String deserializedAs = null;
Line 25:
This is why type can't be null
Line 26: if (type == null) {
Line 27: returnValue = null;
Line 28: } else if (type.equals("java.lang.String")) {
Line 29: deserializedAs = "java.util.String";
Line 81: streamWriter.writeBoolean(instance.getSucceeded());
Line 82: streamWriter.writeString(instance.getExceptionString());
Line 83:
Line 84: Object returnValue = instance.getReturnValue();
Line 85:
this is why return value can't be null
Line 86: if (returnValue == null) {
Line 87: streamWriter.writeString(null);
Line 88: return;
Line 89: }
--
To view, visit http://gerrit.ovirt.org/12252
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a14e8a8705cdd3be8ea24b6da7288bedb01a453
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
