Allon Mureinik has uploaded a new change for review. Change subject: core: Clean up exception in AuditLogDirectorTest ......................................................................
core: Clean up exception in AuditLogDirectorTest Fixed an Exception being printed in AuditLgDirectorTest, caused by the underlying AuditLogableBase trying to access DbFacade. Change-Id: I4ad2abc7c83bf199fc12d35a857cc44322cce0aa Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirectorTest.java 1 file changed, 8 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/64/12264/1 diff --git a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirectorTest.java b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirectorTest.java index 8639d9a..48b1b28 100644 --- a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirectorTest.java +++ b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirectorTest.java @@ -8,6 +8,10 @@ //import static org.mockito.Mockito.when; // +import static org.mockito.Mockito.RETURNS_DEFAULTS; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + import java.util.Collections; import java.util.HashMap; import java.util.Map; @@ -123,9 +127,10 @@ vdsName, AuditLogDirector.UNKNOWN_VARIABLE_VALUE); - AuditLogableBase logable = new AuditLogableBase(); - logable.setVmName(vmName); - logable.setVdsName(vdsName); + AuditLogableBase logable = mock(AuditLogableBase.class, RETURNS_DEFAULTS); + when(logable.getVdsName()).thenReturn("TestVDS"); + when(logable.getVmName()).thenReturn("TestVM"); + String resolvedMessage = AuditLogDirector.resolveMessage(message, logable); Assert.assertEquals(expectedResolved, resolvedMessage); } -- To view, visit http://gerrit.ovirt.org/12264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4ad2abc7c83bf199fc12d35a857cc44322cce0aa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
