Alissa Bonas has posted comments on this change. Change subject: core: Clean up exception in AuditLogDirectorTest ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) one minor comment .................................................... File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirectorTest.java Line 5: * Commented out test class in order to cancel dependency on PowerMock Line 6: * This should be revisited. Line 7: */ Line 8: Line 9: //import static org.mockito.Mockito.when; this is the same import as you added, could you please remove this commented out? Line 10: // Line 11: import static org.mockito.Mockito.RETURNS_DEFAULTS; Line 12: import static org.mockito.Mockito.mock; Line 13: import static org.mockito.Mockito.when; -- To view, visit http://gerrit.ovirt.org/12264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ad2abc7c83bf199fc12d35a857cc44322cce0aa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
