Allon Mureinik has posted comments on this change.
Change subject: core: create a data structure for all Runtime updates logics
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmRepository.java
Line 12: import
org.ovirt.engine.core.common.businessentities.network.VmNetworkInterface;
Line 13: import org.ovirt.engine.core.compat.Guid;
Line 14: import
org.ovirt.engine.core.vdsbroker.vdsbroker.entities.VmInternalData;
Line 15:
Line 16: public class VmRepository {
throughout this class, you're returning colletions which expose the internal
implementation.
Why not wrap them with Collections.unmodifiableXYZ ?
Line 17: private Map<Guid, VM> vmDict;
Line 18: private Map<Guid, VmInternalData> runningVms;
Line 19:
Line 20: private List<Guid> vmsToRerun;
--
To view, visit http://gerrit.ovirt.org/12273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I434b1429dfa184f7a8212843ad7ee2c5a196c783
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
