Roy Golan has posted comments on this change.
Change subject: core: create a data structure for all Runtime updates logics
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmRepository.java
Line 12: import
org.ovirt.engine.core.common.businessentities.network.VmNetworkInterface;
Line 13: import org.ovirt.engine.core.compat.Guid;
Line 14: import
org.ovirt.engine.core.vdsbroker.vdsbroker.entities.VmInternalData;
Line 15:
Line 16: public class VmRepository {
agree. will rework
Line 17: private Map<Guid, VM> vmDict;
Line 18: private Map<Guid, VmInternalData> runningVms;
Line 19:
Line 20: private List<Guid> vmsToRerun;
Line 12: import
org.ovirt.engine.core.common.businessentities.network.VmNetworkInterface;
Line 13: import org.ovirt.engine.core.compat.Guid;
Line 14: import
org.ovirt.engine.core.vdsbroker.vdsbroker.entities.VmInternalData;
Line 15:
Line 16: public class VmRepository {
I see what you mean but my first hunch is that this class is a Data-structure
rather than an Object. this mean its designed less for logic and more to pass
data around.
what do you think about making the class visibility narrower? this class is
surely not public.
Line 17: private Map<Guid, VM> vmDict;
Line 18: private Map<Guid, VmInternalData> runningVms;
Line 19:
Line 20: private List<Guid> vmsToRerun;
--
To view, visit http://gerrit.ovirt.org/12273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I434b1429dfa184f7a8212843ad7ee2c5a196c783
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
