Daniel Erez has posted comments on this change.
Change subject: webadmin: Show warning, if VM provides any non-exportable disks
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java
Line 98:
Line 99: @DefaultMessage("Direct LUN disk(s) will not be part of the
export: {0}.")
Line 100: String directLUNDisksWillNotBePartOfTheExport(String diskList);
Line 101:
Line 102: @DefaultMessage("There are no exportable disks, only the
configuration will be exported.")
Not sure it's an appropriate message for 'Create Snapshot' scenario (seems
relevant only when exporting...)
Maybe something like: There are no disks that can be a part of a Snapshot, only
the VM configuration will be saved in the new Snapshot.
[BTW, isn't it sufficient to display all of these warnings only when exporting
a VM/Template?]
Line 103: String noExportableDisksFoundForTheExport();
Line 104:
Line 105: @DefaultMessage("Error connecting to Virtual Machine using
Spice:\n{0}")
Line 106: String errConnectingVmUsingSpiceMsg(Object errCode);
--
To view, visit http://gerrit.ovirt.org/12286
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I339da4bcab18799603caeafb0171fdcea262ec29
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Libor Spevak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
