Daniel Erez has posted comments on this change.
Change subject: webadmin: Show warning, if VM provides any non-exportable disks
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(2 inline comments)
just few more minor comments...
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelHelper.java
Line 11: import org.ovirt.engine.ui.uicompat.external.StringUtils;
Line 12:
Line 13: public class VmModelHelper {
Line 14:
Line 15: public static enum VmExportType {
the enum name is no longer appropriate - maybe something like 'WarningType'
instead?
Line 16: VM_EXPORT,
Line 17: VM_SNAPSHOT,
Line 18: VM_TEMPLATE
Line 19: }
Line 17: VM_SNAPSHOT,
Line 18: VM_TEMPLATE
Line 19: }
Line 20:
Line 21: public static void sendWarningForNonExportableDisks(Model model,
ArrayList<Disk> vmDisks, VmExportType vmExportType) {
same here...
Line 22: final ArrayList<Disk> sharedImageDisks = new ArrayList<Disk>();
Line 23: final ArrayList<Disk> directLunDisks = new ArrayList<Disk>();
Line 24:
Line 25: for (Disk disk : vmDisks) {
--
To view, visit http://gerrit.ovirt.org/12286
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I339da4bcab18799603caeafb0171fdcea262ec29
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Libor Spevak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
