Liron Aravot has posted comments on this change.
Change subject: core: Remove image when VDSM returns not exist.
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
Line 87: if (e.getErrorCode() ==
VdcBllErrors.ImageDoesNotExistInDomainError) {
Line 88: getReturnValue().setFault(new VdcFault(e,
e.getVdsError().getCode()));
Line 89: log.errorFormat("Image {0} does not exist in
domain {1}. Removing disk from DB.",
Line 90: getDiskImage().getId(),
Line 91: getParameters().getStorageDomainId());
it's tricky - it depends on the flow and the behaviour on the end method, it
should be inspected (currently we run same method from endSuccessfully and
endWIthFailure) - but it should be checked carefully what's the behaviour we
want here.
Line 92: } else {
Line 93: throw e;
Line 94: }
Line 95: }
--
To view, visit http://gerrit.ovirt.org/12077
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36915c44e65e20e3ce222683650a562603e4bb05
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
