Maor Lipchuk has posted comments on this change.
Change subject: core: Remove image when VDSM returns not exist.
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
Line 294: // Setting lock to null because the lock is released in
the child command (RemoveImage)
Line 295: setLock(null);
Line 296: if (vdcReturnValue.getSucceeded()) {
Line 297: // If VDSM returns imageDoesNotExistsInDomain then
there is nothing to delete.
Line 298: if (vdcReturnValue.getFault().getError() ==
VdcBllErrors.ImageDoesNotExistInDomainError) {
Since we set the fault in the removeImageCommand.
See also Kublin comment about it at the previous patch.
The operation was acctualy succeeded, since the image was removed, so I think
we can return here true for succeeded.
The fault was just to indicate the cause of it.
Line 299: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
Line 300: @Override
Line 301: public Void runInTransaction() {
Line 302: endCommand(false);
--
To view, visit http://gerrit.ovirt.org/12077
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36915c44e65e20e3ce222683650a562603e4bb05
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
