Muli Salem has posted comments on this change.
Change subject: engine: Allow Import/Snapshot Duplicate MAC Address
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java
Line 46: if (!getMacPoolManager().addMac(iface.getMacAddress())) {
Line 47: iface.setPlugged(false);
Line 48: getMacPoolManager().forceAddMac(iface.getMacAddress());
Line 49: auditLogMacInUse(iface);
Line 50: log.infoFormat("VmInterfaceManager::Network Interface
{0}'s MAC address is in use, " +
Done
Line 51: "therefore it is being unplugged from VM.",
iface.getName());
Line 52: }
Line 53: }
Line 54:
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java
Line 31: import org.ovirt.engine.core.dao.network.VmNetworkInterfaceDao;
Line 32: import org.ovirt.engine.core.dao.network.VmNetworkStatisticsDao;
Line 33: import org.ovirt.engine.core.utils.RandomUtils;
Line 34:
Line 35: public class VmInterfaceManagerTest {
Done
Line 36:
Line 37: private final String NETWORK_NAME = "networkName";
Line 38: private final String VM_NAME = "vmName";
Line 39:
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 320: USER_UPDATE_VM_POOL_WITH_VMS=VM Pool ${VmPoolName} was updated by
${UserName}, ${VmsCount} VMs were added.
Line 321: USER_UPDATE_VM_POOL_WITH_VMS_FAILED=Failed to update VM Pool
${VmPoolName}(User: ${UserName}).
Line 322: USER_VM_POOL_MAX_SUBSEQUENT_FAILURES_REACHED=Not all VMs where
successfully created in VM Pool ${VmPoolName}.
Line 323: MAC_POOL_EMPTY=No MAC addresses left in the MAC Address Pool.
Line 324: MAC_ADDRESS_IS_IN_USE=VM ${VmName}: Mac Address ${MACAddr} is in use,
therefore Network Interface ${IfaceName} was unplugged.
Done
Line 325: MAC_ADDRESSES_POOL_NOT_INITIALIZED=Mac Address Pool is not
initialized. ${Message}
Line 326: USER_PASSWORD_CHANGED=Password changed successfully for ${UserName}
Line 327: USER_PASSWORD_CHANGE_FAILED=Failed to change password. (User:
${UserName})
Line 328: USER_CLEAR_UNKNOWN_VMS=All VMs' status on Non-Responsive Host
${VdsName} were changed to 'Down' by ${UserName}
--
To view, visit http://gerrit.ovirt.org/12241
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I269157b37426942331002c33a22fa354ba0cf39e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
