Michael Pasternak has posted comments on this change.
Change subject: restapi: Rest API for brick advanced details
......................................................................
Patch Set 4: (3 inline comments)
well done Sahina!,
1. few tiny comments inline
2. please described new /statistics resources in RSDL meta file:
/ovirt-engine/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java
Line 224: protected R addLinks(R model, Class<? extends BaseResource>
suggestedParent, String... subCollectionMembersToExclude) {
Line 225: model = addParents(model);
Line 226: // linkSubCollections called first as addLinks unsets the
grandparent model
Line 227: model = linkSubCollections(model, suggestedParent,
subCollectionMembersToExclude);
Line 228: model = LinkHelper.addLinks(getUriInfo(), model,
suggestedParent);
i'm not sure about this change, we have same use-cases working, unset should
happen only if you pass subCollectionMembersToExclude in linkSubCollections()
Line 229: return model;
Line 230: }
Line 231:
Line 232: protected R addLinks(R model, Class<? extends BaseResource>
suggestedParent, boolean doNotLinkSubCollections) {
Line 404: return entity;
Line 405: }
Line 406: }
Line 407:
Line 408: public class QueryIdResolver<T> extends EntityIdResolver<T> {
why do you need it public?
Line 409:
Line 410: private final VdcQueryType query;
Line 411: private final Class<? extends VdcQueryParametersBase>
queryParamsClass;
Line 412:
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStatisticsResource.java
Line 17:
Line 18: private final Guid subjectId;
Line 19: private AbstractStatisticalQuery<R, Q> query;
Line 20:
Line 21: public BackendStatisticsResource(Class<Q> entityType, Guid
subjectId, AbstractStatisticalQuery<R, Q> query) {
why do you need it public?
Line 22: super(Statistic.class, entityType);
Line 23: this.query = query;
Line 24: this.subjectId = subjectId;
Line 25: }
--
To view, visit http://gerrit.ovirt.org/11391
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie219c7cf59fec8a21a54f34959ee5966eed7d524
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
