Michael Pasternak has posted comments on this change.
Change subject: restapi: Rest API for brick advanced details
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java
Line 224: protected R addLinks(R model, Class<? extends BaseResource>
suggestedParent, String... subCollectionMembersToExclude) {
Line 225: model = addParents(model);
Line 226: // linkSubCollections called first as addLinks unsets the
grandparent model
Line 227: model = linkSubCollections(model, suggestedParent,
subCollectionMembersToExclude);
Line 228: model = LinkHelper.addLinks(getUriInfo(), model,
suggestedParent);
no, but i'd like you fixing the LinkHelper to support this deep, rather than
hacking the usage of LinkHelper,
but if this is too complex change and this patch is quite urgent and this
change doesn't break the old code, - i can live with it.
thanks.
Line 229: return model;
Line 230: }
Line 231:
Line 232: protected R addLinks(R model, Class<? extends BaseResource>
suggestedParent, boolean doNotLinkSubCollections) {
--
To view, visit http://gerrit.ovirt.org/11391
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie219c7cf59fec8a21a54f34959ee5966eed7d524
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
