Allon Mureinik has uploaded a new change for review. Change subject: core: Singleton row mapper for DiskLunMap ......................................................................
core: Singleton row mapper for DiskLunMap Added a singleton row mapper for DiskLunMapDAO, as specified by http://www.ovirt.org/Backend_Coding_Standards . Change-Id: Id20b5a12273990b61937aa6bdceacf8c2977f176 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskLunMapDaoDbFacadeImpl.java 1 file changed, 15 insertions(+), 12 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/72/12572/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskLunMapDaoDbFacadeImpl.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskLunMapDaoDbFacadeImpl.java index 666cdf8..9e42080 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskLunMapDaoDbFacadeImpl.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskLunMapDaoDbFacadeImpl.java @@ -12,6 +12,20 @@ public class DiskLunMapDaoDbFacadeImpl extends DefaultGenericDaoDbFacade<DiskLunMap, DiskLunMapId> implements DiskLunMapDao { + private static final class DiskLunMapRowMapper implements ParameterizedRowMapper<DiskLunMap> { + public static final DiskLunMapRowMapper instance = new DiskLunMapRowMapper(); + + @Override + public DiskLunMap mapRow(ResultSet rs, int rowNum) throws SQLException { + DiskLunMap diskLunMap = new DiskLunMap(); + + diskLunMap.setDiskId(Guid.createGuidFromString(rs.getString("disk_id"))); + diskLunMap.setLunId(rs.getString("lun_id")); + + return diskLunMap; + } + } + public DiskLunMapDaoDbFacadeImpl() { super("DiskLunMap"); } @@ -33,18 +47,7 @@ @Override protected ParameterizedRowMapper<DiskLunMap> createEntityRowMapper() { - return new ParameterizedRowMapper<DiskLunMap>() { - - @Override - public DiskLunMap mapRow(ResultSet rs, int rowNum) throws SQLException { - DiskLunMap diskLunMap = new DiskLunMap(); - - diskLunMap.setDiskId(Guid.createGuidFromString(rs.getString("disk_id"))); - diskLunMap.setLunId(rs.getString("lun_id")); - - return diskLunMap; - } - }; + return DiskLunMapRowMapper.instance; } @Override -- To view, visit http://gerrit.ovirt.org/12572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id20b5a12273990b61937aa6bdceacf8c2977f176 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
