Liron Aravot has posted comments on this change.
Change subject: core: Allow force re-election of a specific host as SPM
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ReinitializeSPMCommand.java
Line 24: }
Line 25:
Line 26: @Override
Line 27: protected boolean canDoAction() {
Line 28: setVdsId(getParameters().getPrefferedSPMId());
perhaps just pass it in the parameters vdsid member? seems like a duplication..
Line 29:
Line 30: if (getVds() == null) {
Line 31: return failCanDoAction(VdcBllMessages.VDS_NOT_EXIST);
Line 32: }
Line 28: setVdsId(getParameters().getPrefferedSPMId());
Line 29:
Line 30: if (getVds() == null) {
Line 31: return failCanDoAction(VdcBllMessages.VDS_NOT_EXIST);
Line 32: }
perhaps check here if the host is in storage pool
Line 33:
Line 34: if (getVds().getStatus() != VDSStatus.Up) {
Line 35: return
failCanDo(VdcBllMessages.CANNOT_REINIT_SPM_VDS_NOT_UP);
Line 36: }
--
To view, visit http://gerrit.ovirt.org/12489
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife292b85270e6aa8f5bf723ad7d3fa84e325d3d8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
